/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

/azp run

I see 2 basic options: 1) continue to only run PREfast on x64fre only, that means we skip the Build_x86_StaticAnalysis and Build_arm64_StaticAnalysis stages, which hopefully will allow the pipeline to finish even sooner, 2) adjust the code cited above to enable running PREfast for x86 and arm64 in the Build_x86_StaticAnalysis and Build_arm64_StaticAnalysis stages.

@alexlamtest I have updated current PR with option 1. Below are some of the results while making the decision:

• Original flow
  • Built Time: 2h 26m 32s
  • Sum of All Jobs' Time: 582 min
• Run PREfast for all 3 archs
  • Built Time: 1h 40m 25s (-31.5%)
  • Sum of All Jobs' Time: 793 min (+36.3%)
• Run PREfast for x64
  • Built Time: 1h 27m 36s (-40%)
  • Sum of All Jobs' Time: 607 min (+4.3%)

/azp run

I see 2 basic options: 1) continue to only run PREfast on x64fre only, that means we skip the Build_x86_StaticAnalysis and Build_arm64_StaticAnalysis stages, which hopefully will allow the pipeline to finish even sooner, 2) adjust the code cited above to enable running PREfast for x86 and arm64 in the Build_x86_StaticAnalysis and Build_arm64_StaticAnalysis stages.

@alexlamtest I have updated current PR with option 1. Below are some of the results while making the decision:

• Original flow

  • Built Time: 2h 26m 32s
  • Sum of All Jobs' Time: 582 min

• Run PREfast for all 3 archs

  • Built Time: 1h 40m 25s (-31.5%)
  • Sum of All Jobs' Time: 793 min (+36.3%)

• Run PREfast for x64

  • Built Time: 1h 27m 36s (-40%)
  • Sum of All Jobs' Time: 607 min (+4.3%)

@alexlamtest, I will suggest let Muyuan to checkin the one only improve performance first, which the result is promising and without increase much build agent cost (i.e. 4.3% only)
And if we believe it is necessary to run statistic analysis against all the build architect, it should be an easy change later on.

/azp run

_>how I can confirm whether PREfast results are the same for x86, x64, and arm64?
You can use a OneBranch pipeline: https://microsoft.visualstudio.com/ProjectReunion/_build/results?buildId=121978283&view=logs&j=096205eb-4599-56da-affa-13246cc49eac. If you look at the end of each build job, there is a "Guardian: Post Analysis" task there. PREfast results can be found in there (non-OneBranch pipelines, such as the validation pipeline run for this PR, does not have that Guardian task). But note that for the pipeline run I cited above, even for the x64 build, there is no PREfast results shown in the Guardian task. That's simply because the cited pipeline run's parameter has runStaticAnalysis=false. If you set that parameter to true when you manually trigger the pipeline to run, or you use yml code changes to set the parameter to true, then you should be able to find PREfast results there, at least in the x64 cause. You would want to enable PREFast to run also for x86 and amd64. Then you should get PREfast results for all 3 architectures and you can confirm that their results are very similar. From my experience many months ago, the difference was 5% or less, and x64 usually found the most PREfast issues. Hope this helps!

Yes, I agree with Gordon that we can submit the changes for option #1. The latest perf numbers look inline with my expectation. The changes LGTM, I already approved the PR. Thank you for this great work!